Fix build issues after upgrading reqwest from 0.12.0 to 0.12.14#226
Fix build issues after upgrading reqwest from 0.12.0 to 0.12.14#226douggynix wants to merge 4 commits intoTrueLayer:mainfrom
Conversation
update other cargo dependencies
…rom reqwest 0.12.14
AS1100K
left a comment
There was a problem hiding this comment.
The version update isn't required and will cause breaking change for the dependents. If a dependency is set to a version lets say 1.2.3, this means >=1.2.3, <2.0.0. This is specified in The Cargo Book.
So, since we are specifying the dependencies like 1.0.0, we are saying that just use any version from >=1.0.0, <2.0.0, this ensure that the dependent crate can use any version of our dependency. For example: You changed the version of anyhow from 1.0.0 to 1.0.97, this will make the dependent crate to use >=1.0.97 version of anyhow.
I hope you understand that updating dependencies is a huge breaking changes, and I strongly believe that the maintainers would also say the same once they review this PR.
|
I underystand the concern about broken changes and dependency update management. We can close this PR if it is against the maintainer Philosophy for this package. we should be thinking of upgrading anyhow versions, as it is really old comparing to the latest one available. |
|
Thanks for the PR @douggynix, we would prefer to not make a breaking changes, so I'm closing this in favour of #225 |

Reqwest 0.12.14 introduces a breaking change that removes a deprecated function.
Reqwest-middleware exposes a public function with the same prototype definition that has been removed:
this function above has been removed from
reqwest::RequestBuilderand was not advised to be used either.So, I remove this function as well as suggested by
reqwestIn addition to that, I also upgrade most of the remaining cargo dependencies for each modules. So, we were using really old packages. Migrating them now to latest should ease maintenance and upgrade for future releases.