Add search payments providers endpoint + statement reference to merchant account #330
Conversation
| return Beneficiary.merchantAccount() | ||
| .merchantAccountId(gbpAccount.getId()) | ||
| .reference(UUID.randomUUID().toString()) | ||
| .statementReference(RandomStringUtils.randomAlphanumeric(18)) |
There was a problem hiding this comment.
statementReference is supported for GBP only at API level
|
|
||
| private List<CustomerSegment> customerSegments; | ||
|
|
||
| private Capabilities capabilities; |
There was a problem hiding this comment.
I could not reuse the same Capabilities object already defined in the entities folder (currently used for responses) because in the request BankTransferCapabilites, VrpSweepingCapabilities and VrpCommercialCapabilities are empty objects (whereas they have additional properties in the response).
I initially considered reusing the same objects anyway as adding additional properties in the request was not creating side effects in the APIs, but then I thought it might have led to confusion clients if they were expecting to use those additional properties for filtering out providers
| @Getter | ||
| @ToString | ||
| @EqualsAndHashCode | ||
| public class AuthorizationFlow { |
There was a problem hiding this comment.
Needed, right? Like, we don't have already a AuthFlow model with just the config object
There was a problem hiding this comment.
That's correct, we have another AuthorizationFlow entity but it's different (it's a wrapper for an actions object and it's used in the start auth flow API response)
|
|
||
| @Value | ||
| public class SearchPaymentProvidersResponse { | ||
| List<PaymentsProvider> items; |
There was a problem hiding this comment.
Is it expected that we're not adding BIN ranges to this PaymentsProvider type, right? Happy to skip them
There was a problem hiding this comment.
I actually missed that, I would add it to keep feature parity with the API, unless you think is really not needed?
Description
statementReferenceto merchant account beneficiary (ACL-223)Type of change
Please select multiple options if required.
Checklist: