PX-2134 Prepare 2.3.0 release #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tl-yury-vashchylau
requested review from
tl-lukasz-franieczek and
tl-yura-kolesnikov
Contributor
Author
|
Continuing from #84 (new branch and PR name) |
![tl-security-scanner[bot]](https://avatars.githubusercontent.com/u/21106665?s=60&v=4){kind=small}
| 81AB9BB72411601600AC10FF /* LaunchScreen.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; name = LaunchScreen.storyboard; path = DemoApp/LaunchScreen.storyboard; sourceTree = "<group>"; }; | ||
| 89C6BE57DB24E9ADA2F236DE /* Pods-DemoApp-DemoAppTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-DemoApp-DemoAppTests.release.xcconfig"; path = "Target Support Files/Pods-DemoApp-DemoAppTests/Pods-DemoApp-DemoAppTests.release.xcconfig"; sourceTree = "<group>"; }; | ||
| E57B29A4642B023C386F920A /* Pods-DemoApp-DemoAppUITests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-DemoApp-DemoAppUITests.release.xcconfig"; path = "Target Support Files/Pods-DemoApp-DemoAppUITests/Pods-DemoApp-DemoAppUITests.release.xcconfig"; sourceTree = "<group>"; }; | ||
| ED297162215061F000B7C4FE /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = System/Library/Frameworks/JavaScriptCore.framework; sourceTree = SDKROOT; }; |
There was a problem hiding this comment.
[INFO severity] Hard-coded IBAN detected. IBANs are generally considered PII, especially if the given IBAN might belong to a person. Consider storing the IBAN similar to other personally identifiable information.
| 2D16E6871FA4F8E400B85C8A /* Frameworks */ = { | ||
| isa = PBXGroup; | ||
| children = ( | ||
| ED297162215061F000B7C4FE /* JavaScriptCore.framework */, |
There was a problem hiding this comment.
[INFO severity] Hard-coded IBAN detected. IBANs are generally considered PII, especially if the given IBAN might belong to a person. Consider storing the IBAN similar to other personally identifiable information.
…est" as bundle exec pod install wasn't working with it.
…sic UI test" as bundle exec pod install wasn't working with it." This reverts commit f7e847c.
tl-lucas-lima
previously approved these changes
Jan 28, 2025
…tion process for Expo 52
Contributor
Author
tl-yury-vashchylau
left a comment
tl-yury-vashchylau
left a comment
There was a problem hiding this comment.
I've tested the Expo thing on iOS and everything looks good to me
tl-lukasz-franieczek
approved these changes
Jan 31, 2025
Contributor
Author
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.