Skip to content

Don't spam log when hostname cannot resolve #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lordwelch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't spam log when hostname cannot resolve #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,10 @@ func handleStatus(w http.ResponseWriter, r *http.Request) {

func isAddressReachable(addr string) (bool, error) {
pinger, err := probing.NewPinger(addr)
// This error is from resolving a host that's currently off may not have a dns entry and we don't want to spam the log.
// We could display this in the web interface in the future instead of ignoring it.
if err != nil {
return false, fmt.Errorf("error creating pinger: %v", err)
return false, nil
}
// Set privileged mode based on config
pinger.SetPrivileged(cfg.Ping.Privileged)
Expand Down