get_unit_tags() methods for manual or OTA aliases #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Very much +1 for this. I think I pinged @taclane about it right after the first beta went out on his repo. It would be great to have a way to get the OTA list from the plugin interface. Happy to see that land here. |
Contributor
|
@robotastic for what it's worth, I did read over the code and compiled it. This all looks good to me. |
Collaborator
|
Good prod - let me go roll it in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to the OTA PR #1074, unit tags and OTA tags should provide a function to return the respective alias vectors if needed by another process.
While not presently used in trunk-recorder itself, this would allow plugins to iterate across
sys->get_unit_tags()orsys->get_unit_tags_ota()much the same way it can presently do so with
sys->get_talkgroups()A example use would be to periodically poll the length of OTA tags, then display or emit the N newest entries from the front of the vector if a change in length is noted.