Update to support future Rdio alias uploads #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taclane
changed the title
Contributor
Author
|
Minor update, Thinline-Dynamic-Solutions/ThinLineRadio#48 was approved, and this code correctly passes it alias data via "sources". Including alias data will not affect unpatched rdio servers, as the parser will simply ignore extraneous |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trunk Recorder currently does not send alias data (OTA or manual) via the Rdio Scanner plugin. The Rdio server does not parse aliases via the API, but the intent is to correct this on both ends.
This is an implementation of a patch by @poisonednumber poisonednumber@0e07906 with additions to also cover a future "units" endpoint for this data as proposed in the unreleased Rdio v7 API.
Enabling both "sources" and "units" does not seem advisable at this time. Rdio 7v may process them both, leading to redundant metadata being added to the call. A PR has been proposed for ThinLineRadio to test this feature while independent development continues with Rdio Scanner Thinline-Dynamic-Solutions/ThinLineRadio#48.