Add optional whitelist/blacklist for talkgroups on RDIO upload plugin… #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Rdio Scanner uploader plugin with (1) per-system talkgroup
allow/deny filtering using glob-style patterns, and (2) targeted libcurl
robustness + observability fixes (timeouts, better error reporting, and more
correct status/result handling). Existing configs continue to work unchanged.
Rdio Scanner Plugin (rdioscanner_uploader) — Changes in this PR
===============================================================================
Added two optional keys on each Rdio “system” object:
talkgroupAllow (array)
If provided and non-empty, the talkgroup MUST match at least one pattern
to upload. If it doesn’t match, the call is skipped.
talkgroupDeny (array)
If provided and non-empty, any matching talkgroup is skipped.
Patterns are glob-style and compiled to fully-anchored regex (^...$):
Filter evaluation order:
Additional notes:
(e.g., 50712), so pattern lists can contain strings or numbers.
the talkgroup ID for easy debugging.
The upload path now includes these changes:
Observability:
Thread-safety / stability:
Timeouts:
Correctness fixes in multi + HTTP handling:
whether the transfer itself failed vs. a non-2xx HTTP response.
(the old flow attempted to read it after cleanup).
Success criteria expanded:
and explicitly supports 202 Accepted (logs “Accepted (202) - stub cached” vs.
“Success” for other success statuses).
Safer lifetime for mime string inputs:
(audioType/dateTime/system/talkgroup/etc.) so the backing memory is guaranteed
to remain valid until after the request completes.
Net effect
improves diagnostics (curl error buffer + clearer error/success logging).