Merge pull request #1321 from Trusted-AI/dev_1.8.0

Update to ART 1.8.0

Author: beat-buesser

.github/actions/goturn/Dockerfile

@@ -0,0 +1,51 @@
+# Get base from a pytorch image
+FROM pytorch/pytorch:1.6.0-cuda10.1-cudnn7-runtime
+
+# Set to install things in non-interactive mode
+ENV DEBIAN_FRONTEND noninteractive
+
+# Install system wide softwares
+RUN apt-get update \
+     && apt-get install -y \
+        libgl1-mesa-glx \
+        libx11-xcb1 \
+        git \
+        gcc \
+        mono-mcs \
+        libavcodec-extra \
+        ffmpeg \
+        curl \
+        libsndfile-dev \
+        libsndfile1 \
+     && apt-get install -y libsm6 libxext6 \
+     && apt-get install -y libxrender-dev \
+     && apt-get clean all \
+     && rm -r /var/lib/apt/lists/*
+
+RUN /opt/conda/bin/conda install --yes \
+    astropy \
+    matplotlib \
+    pandas \
+    scikit-learn \
+    scikit-image
+
+# Install necessary libraries for goturn
+RUN pip install torch==1.4
+RUN pip install tensorflow==2.1.4
+RUN pip install torchaudio==0.5.0
+RUN pip install pytest
+RUN pip install numba
+RUN pip install scikit-learn==0.20
+RUN pip install pytest-cov
+RUN pip install gdown
+
+RUN git clone https://github.com/nrupatunga/goturn-pytorch.git /tmp/goturn-pytorch
+RUN cd /tmp/goturn-pytorch && pip install -r requirements.txt
+
+RUN pip install numpy==1.20.3
+
+ENV PYTHONPATH "${PYTHONPATH}:/tmp/goturn-pytorch/src"
+ENV PYTHONPATH "${PYTHONPATH}:/tmp/goturn-pytorch/src/scripts"
+
+RUN mkdir /tmp/goturn-pytorch/src/goturn/models/checkpoints
+RUN cd /tmp/goturn-pytorch/src/goturn/models/checkpoints && gdown https://drive.google.com/uc?id=1GouImhqpcoDtV_eLrD2wra-qr3vkAMY4

.github/actions/goturn/action.yml

@@ -0,0 +1,7 @@
+name: 'Test GOTURN'
+description: 'Run tests for GOTURN'
+runs:
+  using: 'composite'
+  steps:
+    - run: $GITHUB_ACTION_PATH/run.sh
+      shell: bash

.github/actions/goturn/run.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+
+exit_code=0
+
+pytest --cov-report=xml --cov=art --cov-append -q -vv tests/estimators/object_tracking/test_pytorch_goturn.py --framework=pytorch --durations=0
+if [[ $? -ne 0 ]]; then exit_code=1; echo "Failed estimators/object_tracking/test_pytorch_goturn tests"; fi
+
+exit ${exit_code}

.github/workflows/ci-goturn.yml

@@ -0,0 +1,32 @@
+name: CI PyTorchGoturn
+on:
+  # Run on manual trigger
+  workflow_dispatch:
+
+  # Run on pull requests
+  pull_request:
+    paths-ignore:
+      - '*.md'
+
+  # Run when pushing to main or dev branches
+  push:
+    branches:
+      - main
+      - dev*
+
+  # Run scheduled CI flow daily
+  schedule:
+    - cron: '0 8 * * 0'
+
+jobs:
+  test_pytorch_goturn:
+    name: PyTorchGoturn
+    runs-on: ubuntu-latest
+    container: adversarialrobustnesstoolbox/art_testing_envs:goturn
+    steps:
+      - name: Checkout Repo
+        uses: actions/[email protected]
+      - name: Run Test Action
+        uses: ./.github/actions/goturn
+      - name: Upload coverage to Codecov
+        uses: codecov/[email protected]

.github/workflows/ci-legacy.yml

@@ -20,7 +20,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-16.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:

.github/workflows/ci-mxnet.yml

@@ -20,7 +20,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-16.04
+    runs-on: ubuntu-18.04
     strategy:
       fail-fast: false
       matrix:

.github/workflows/ci-pytorch-fasterrcnn.yml renamed to .github/workflows/ci-pytorch-object-detectors.yml

@@ -1,4 +1,4 @@
-name: CI PyTorchFasterRCNN
+name: CI PyTorchObjectDetectors
 on:
   # Run on manual trigger
   workflow_dispatch:
@@ -20,7 +20,7 @@ on:
 
 jobs:
   test_pytorch_fasterrcnn:
-    name: PyTorchFasterRCNN
+    name: PyTorchObjectDetectors
     runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
@@ -43,7 +43,9 @@ jobs:
           pip install torch==1.6.0+cpu -f https://download.pytorch.org/whl/torch_stable.html
           pip install torchvision==0.7.0+cpu -f https://download.pytorch.org/whl/torch_stable.html
           pip install torchaudio==0.6.0 -f https://download.pytorch.org/whl/torch_stable.html
-      - name: Run Test Action
+      - name: Run Test Action - test_pytorch_object_detector
+        run: pytest --cov-report=xml --cov=art --cov-append -q -vv tests/estimators/object_detection/test_pytorch_object_detector.py --framework=pytorch --durations=0
+      - name: Run Test Action - test_pytorch_faster_rcnn
         run: pytest --cov-report=xml --cov=art --cov-append -q -vv tests/estimators/object_detection/test_pytorch_faster_rcnn.py --framework=pytorch --durations=0
       - name: Upload coverage to Codecov
         uses: codecov/[email protected]

.github/workflows/ci-style-checks.yml

@@ -51,7 +51,7 @@ jobs:
         run: mypy art
       - name: pytest-flake8
         if: ${{ always() }}
-        run: pytest --flake8 -v -m flake8
+        run: pytest --flake8 -v -m flake8 --ignore=contrib
       - name: black
         if: ${{ always() }}
         run: |

art/__init__.py

@@ -12,7 +12,7 @@
 from art import preprocessing
 
 # Semantic Version
-__version__ = "1.7.2"
+__version__ = "1.8.0.dev0"
 
 # pylint: disable=C0103
 

art/attacks/attack.py

@@ -85,12 +85,16 @@ def replacement_function(self, *args, **kwargs):
                 setattr(cls, item, new_function)
 
 
-class Attack(abc.ABC, metaclass=InputFilter):
+class Attack(abc.ABC):
     """
     Abstract base class for all attack abstract base classes.
     """
 
     attack_params: List[str] = list()
+    # The _estimator_requirements define the requirements an estimator must satisfy to be used as a target for an
+    # attack. They should be a tuple of requirements, where each requirement is either a class the estimator must
+    # inherit from, or a tuple of classes which define a union, i.e. the estimator must inherit from at least one class
+    # in the requirement tuple.
     _estimator_requirements: Optional[Union[Tuple[Any, ...], Tuple[()]]] = None
 
     def __init__(
@@ -111,7 +115,7 @@ def __init__(
         if self.estimator_requirements is None:
             raise ValueError("Estimator requirements have not been defined in `_estimator_requirements`.")
 
-        if not all(t in type(estimator).__mro__ for t in self.estimator_requirements):
+        if not self.is_estimator_valid(estimator):
             raise EstimatorError(self.__class__, self.estimator_requirements, estimator)
 
         self._estimator = estimator
@@ -155,6 +159,24 @@ def _check_params(self) -> None:
         if not isinstance(self.tensor_board, (bool, str)):
             raise ValueError("The argument `tensor_board` has to be either of type bool or str.")
 
+    def is_estimator_valid(self, estimator) -> bool:
+        """
+        Checks if the given estimator satisfies the requirements for this attack.
+
+        :param estimator: The estimator to check.
+        :return: True if the estimator is valid for the attack.
+        """
+
+        for req in self.estimator_requirements:
+            # A requirement is either a class which the estimator must inherit from, or a tuple of classes and the
+            # estimator is required to inherit from at least one of the classes
+            if isinstance(req, tuple):
+                if all(p not in type(estimator).__mro__ for p in req):
+                    return False
+            elif req not in type(estimator).__mro__:
+                return False
+        return True
+
 
 class EvasionAttack(Attack):
     """
@@ -175,7 +197,7 @@ def generate(  # lgtm [py/inheritance/incorrect-overridden-signature]
 
         :param x: An array with the original inputs to be attacked.
         :param y: Correct labels or target labels for `x`, depending if the attack is targeted
-               or not. This parameter is only used by some of the attacks.
+                  or not. This parameter is only used by some of the attacks.
         :return: An array holding the adversarial examples.
         """
         raise NotImplementedError
@@ -373,7 +395,7 @@ class MembershipInferenceAttack(InferenceAttack):
     Abstract base class for membership inference attack classes.
     """
 
-    def __init__(self, estimator: Union["CLASSIFIER_TYPE"]):
+    def __init__(self, estimator):
         """
         :param estimator: A trained estimator targeted for inference attack.
         :type estimator: :class:`.art.estimators.estimator.BaseEstimator`