Fix missing transfer to device in ProjectedGradientDescentPyTorch#2558
Merged
beat-buesser merged 1 commit intodev_1.19.1from Jan 20, 2025
Merged
Fix missing transfer to device in ProjectedGradientDescentPyTorch#2558beat-buesser merged 1 commit intodev_1.19.1from
beat-buesser merged 1 commit intodev_1.19.1from
Conversation
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev_1.19.1 #2558 +/- ##
===========================================
Coverage 85.41% 85.41%
===========================================
Files 334 334
Lines 31001 31001
Branches 5300 5300
===========================================
+ Hits 26478 26481 +3
+ Misses 3055 3053 -2
+ Partials 1468 1467 -1
|
kieranfraser
approved these changes
Jan 20, 2025
Collaborator
kieranfraser
left a comment
There was a problem hiding this comment.
LGTM - tested on a GPU enabled instance and have replicated the issue error and confirmed this PR fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a missing transfer to device in
ProjectedGradientDescentPyTorch.