Skip to content

fix: remove flow tests#79

Merged
JoelVR17 merged 2 commits intoTrustless-Work:developfrom
FabianSanchezD:fix/remove-flow-test
Mar 13, 2026
Merged

fix: remove flow tests#79
JoelVR17 merged 2 commits intoTrustless-Work:developfrom
FabianSanchezD:fix/remove-flow-test

Conversation

@FabianSanchezD
Copy link
Contributor

@FabianSanchezD FabianSanchezD commented Mar 13, 2026

Summary by CodeRabbit

  • Refactor
    • Removed ROI management dashboard and related pages from the application.
    • Removed campaign creation and testing workflows.
    • Consolidated vault management functionality under the campaigns section.

@vercel
Copy link

vercel bot commented Mar 13, 2026

@FabianSanchezD is attempting to deploy a commit to the Trustless Work Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR removes the entire flow-roi and flow-testing feature modules including their page routes, components, hooks, services, and types, while adding ROI vault and campaign update APIs to the campaigns feature module.

Changes

Cohort / File(s) Summary
Flow ROI Pages
apps/backoffice-tokenization/src/app/flow-roi/page.tsx
Removes the RoiPage route component and its Suspense wrapper.
Flow Testing Pages
apps/backoffice-tokenization/src/app/flow-testing/page.tsx, apps/backoffice-tokenization/src/app/flow-testing/[contractId]/page.tsx, apps/backoffice-tokenization/src/app/flow-testing/create/page.tsx
Removes three Next.js page routes for flow-testing features (main list, contract details, and campaign creation).
Flow ROI Feature Components
apps/backoffice-tokenization/src/features/flow-roi/RoiDashboard.tsx, apps/backoffice-tokenization/src/features/flow-roi/components/*
Removes the main RoiDashboard component, CampaignRoiCard, CampaignRoiList, CreateRoiDialog, and VaultInfoPanel components.
Flow ROI Hooks & Services
apps/backoffice-tokenization/src/features/flow-roi/hooks/*, apps/backoffice-tokenization/src/features/flow-roi/services/roi.service.ts, apps/backoffice-tokenization/src/features/flow-roi/types.ts
Removes useCreateRoi and useVaultInfo hooks, roi.service API functions (deployVault, enableVault, getVaultIsEnabled, getVaultRoiPercentage, etc.), and Campaign/VaultInfo types.
Flow Testing Feature Components
apps/backoffice-tokenization/src/features/flow-testing/FlowTesting.tsx, apps/backoffice-tokenization/src/features/flow-testing/CreateCampaignFlow.tsx, apps/backoffice-tokenization/src/features/flow-testing/EscrowDetail.tsx, apps/backoffice-tokenization/src/features/flow-testing/AddLoanDialog.tsx
Removes primary feature components for campaign management, flow orchestration, and escrow detail views.
Flow Testing Step Components
apps/backoffice-tokenization/src/features/flow-testing/steps/*
Removes three multi-step flow orchestrators: StepCampaignForm, StepInitializeEscrow, and StepTokenizeEscrow.
Flow Testing UI Components
apps/backoffice-tokenization/src/features/flow-testing/components/*
Removes CampaignCard, CampaignList, EscrowHeader, EscrowLoansCard, FlowStepper, MilestoneRow, MilestonesList, and PhaseStatusRow components.
Flow Testing Hooks, Services & Constants
apps/backoffice-tokenization/src/features/flow-testing/hooks/useCampaignFlow.ts, apps/backoffice-tokenization/src/features/flow-testing/services/*, apps/backoffice-tokenization/src/features/flow-testing/constants.ts, apps/backoffice-tokenization/src/features/flow-testing/types.ts
Removes campaign flow state hook, campaign and Soroban services, all exported constants (CORE_API, STATUS_LABELS, FLOW_STEPS, etc.), and type definitions (Campaign, CampaignFormData, PhaseStatus).
Campaigns Feature ROI API Additions
apps/backoffice-tokenization/src/features/campaigns/services/campaigns.api.ts, apps/backoffice-tokenization/src/features/campaigns/services/soroban.service.ts
Adds enableVault, getVaultIsEnabled, updateCampaignVaultId functions and submitAndExtractAddress helper for transaction handling.
Campaigns Feature ROI Component Updates
apps/backoffice-tokenization/src/features/campaigns/components/roi/*, apps/backoffice-tokenization/src/features/campaigns/hooks/*
Updates import paths for useToggleVault and useFundRoi hooks and roi components; removes campaignId parameter from ToggleVaultButton and simplifies its onSuccess callback; updates API call signatures.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested reviewers

  • armandocodecr
  • JoelVR17
  • zkCaleb-dev

🐰 Whiskers twitching with delight

Old flows fade like morning dew,
Campaigns rise with vibrant hue,
Routes dissolve, services align,
The refactored code will shine!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: remove flow tests' accurately describes the primary change: removal of flow-related test and feature code from the backoffice-tokenization app.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FabianSanchezD FabianSanchezD marked this pull request as ready for review March 13, 2026 14:43
@FabianSanchezD FabianSanchezD marked this pull request as draft March 13, 2026 14:50
@FabianSanchezD FabianSanchezD marked this pull request as ready for review March 13, 2026 15:35
@JoelVR17 JoelVR17 merged commit 297b95f into Trustless-Work:develop Mar 13, 2026
0 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants