This repository was archived by the owner on Jan 25, 2024. It is now read-only.
[WIP] Open external links in external browser#21
Open
ahstro wants to merge 3 commits intoTrustroots:masterfrom
Open
[WIP] Open external links in external browser#21ahstro wants to merge 3 commits intoTrustroots:masterfrom
ahstro wants to merge 3 commits intoTrustroots:masterfrom
Conversation
Create injected JavaScript in a single place and then inject it both as a WebView prop and with the `injectJavaScript`-method on `onLoadEnd`. This is preparatory for adding more injected JavaScript.
Opens external links present onLoadEnd in external browser, but doesn't yet handle the SPA-aspect of the site
ahstro
commented
Aug 29, 2019
| <WebView | ||
| domStorageEnabled | ||
| injectedJavaScript={this.appInfoJavaScript} | ||
| injectedJavaScript={this.injectedJavaScript} |
Contributor
Author
There was a problem hiding this comment.
I'm not sure this line is actually needed at all, since we're loading the same code on every onLoadEnd, but I donno 🤷♀️
Contributor
|
I merged #20 so this is now good to rebase |
Contributor
Author
|
Cool, I'll get on that asap :) Any input on whether this should be done or not, and if so, if my potential solution makes sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, so I was playing around with the code and wanted to see if I could get external links (i.e. ones not hosted on
Settings.BASE_URL) to open in the external browser instead of in theWebView, but ran into a bit of a hurdle and wanted to see if anyone other than me want this before continuing.The code I've got now seems to work fine with converting any external link present when the page loads, but since the website is an SPA and some links are created after the page has been loaded, we're going to need to do some (possibly horrifying) magic to make those open externally, possibly with a
MutationObserver, unless anyone has any better suggestions (please 🙏 ).This PR is based on #20, so 448c193 shouldn't really be in this PR, sorry about the mess.