This repository was archived by the owner on Jan 25, 2024. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started playing with some code and I had trouble with my editor integrations. 😅
You might have Prettier directly in the editor as dependency or installed globally?
I've:
Now when I modify files, they get reformatted as I save them and for others without editor integrations as they commit them.
Removed
semi: 'never'rule from Eslint config — I don't have preference over the way or the other but it was causing trouble by conflicting between Eslint and Prettier.First Eslint said "never" is not valid (needs to be "off", "warn", "error"). Then I switched it to error and it became a conflict between Eslint and Prettier:
It was a battle of two mighty ones so I just figured let them find peace and harmony and remove all rules. 😅
This will add tons of noise next time you commit anything since it'll reformat files by Prettier and by this rule-removal.
Happy to just
npx prettier . --writeit all right next up and move on. 😁Thoughts?