Post updated event serialization

[mike182uk]

Refactor PostUpdatedEvent to implement SerializableEvent to comply with ADR-0011.

---

Linear Issue: BER-3164

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[coderabbitai]

Walkthrough

This pull request refactors PostUpdatedEvent to support serialization by replacing the full Post object parameter with a numeric postId. The event class now implements SerializableEvent with toJSON() and fromJSON() methods. Consumers like FediverseBridge are updated to accept a KnexPostRepository dependency and fetch posts by ID from the repository, with guards added for missing or non-internal posts. The event is registered with the EventSerializer in app.ts, and comprehensive test coverage is added for the new serialization logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Serializable post reposted event #1541: Applies the same refactoring pattern—converting post events to use postId for serializability while updating consumers to inject KnexPostRepository, fetch posts by ID, and guard against missing posts.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: refactoring PostUpdatedEvent to implement SerializableEvent with serialization support.
Description check	✅ Passed	The description clearly explains the refactoring of PostUpdatedEvent to implement SerializableEvent per ADR-0011, with relevant context linking to the Linear issue.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cursor/BER-3164-post-updated-event-serialization-d792

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mike182uk]

@cursoragent lets add the non-static version like in the other events whilst we are here

[cursor]

Taking a look!

 

[mike182uk]

@cursoragent These tests should be consistent with the other events

[cursor]

Restructured the PostUpdatedEvent tests to be consistent with other event tests:

• Added nested describe blocks for each method (getName, getPostId, toJSON, fromJSON, round-trip serialization)
• Added test case for postId being null
• Added round-trip serialization test
• Using .toBe() instead of .toEqual() for primitive comparisons

 

[coderabbitai]

🧹 Nitpick comments (1)

src/activitypub/fediverse-bridge.ts (1)

22-22: Repository injection pattern is consistent with codebase conventions.

The guideline "repositories should not be used directly" is noted, but this pattern is established across the codebase: NotificationEventService, PostInteractionCountsService, FeedUpdateService, GhostPostService, PostService, controllers, and other event handlers all inject and use KnexPostRepository directly. There is no PostService layer providing an alternative.

The implementation correctly guards against null and non-internal authors. The postRepository parameter name matches the DI registration at src/configuration/registrations.ts:303, satisfying Awilix CLASSIC mode requirements.

If the team intends to enforce repository abstraction, it would require broader refactoring beyond this change.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/activitypub/fediverse-bridge.ts` at line 22, The current use of
KnexPostRepository in src/activitypub/fediverse-bridge.ts is consistent with the
codebase pattern, so do not refactor to a service now; keep the constructor
parameter named postRepository and continue injecting KnexPostRepository
directly, ensure the existing null checks and non-internal author guards around
usages remain intact, and make no change unless you plan a broader
repository-abstraction refactor across
NotificationEventService/PostInteractionCountsService/FeedUpdateService/GhostPostService/PostService
and related DI registrations.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/activitypub/fediverse-bridge.ts`:
- Line 22: The current use of KnexPostRepository in
src/activitypub/fediverse-bridge.ts is consistent with the codebase pattern, so
do not refactor to a service now; keep the constructor parameter named
postRepository and continue injecting KnexPostRepository directly, ensure the
existing null checks and non-internal author guards around usages remain intact,
and make no change unless you plan a broader repository-abstraction refactor
across
NotificationEventService/PostInteractionCountsService/FeedUpdateService/GhostPostService/PostService
and related DI registrations.