Post created event serialization by mike182uk · Pull Request #1599 · TryGhost/ActivityPub

mike182uk · 2026-02-18T15:18:54Z

Refactor PostCreatedEvent to implement SerializableEvent to comply with ADR-0011 for serializable domain events.

Linear Issue: BER-3174

…(ADR-0011) - Updated PostCreatedEvent to only contain postId instead of full Post entity - Implemented toJSON() and fromJSON() methods for serialization - Updated event publisher in post.repository.knex.ts to pass postId - Updated FediverseBridge, FeedUpdateService, and NotificationEventService consumers to look up post from repository - Registered PostCreatedEvent with EventSerializer in app.ts - Added unit tests for serialization/deserialization - Updated existing tests to use the new PostCreatedEvent signature Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

cursor · 2026-02-18T15:18:56Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

coderabbitai · 2026-02-18T15:22:22Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch cursor/BER-3174-post-created-event-serialization-d22a

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

mike182uk · 2026-02-18T15:35:36Z

src/post/post-created.event.unit.test.ts

+
+import { PostCreatedEvent } from '@/post/post-created.event';
+
+describe('PostCreatedEvent', () => {


@cursoragent These should be consistent with the other events

Taking a look!

mike182uk · 2026-02-18T15:36:15Z

src/post/post-created.event.ts

+        return this.postId;
    }

    static getName(): string {


@cursoragent lets also add the non static version of this whilst we are here

This has already been addressed in my last commit. The PostCreatedEvent now has both the static and instance getName() methods:

getName(): string { return PostCreatedEvent.getName(); } static getName(): string { return 'post.created'; }

The tests have also been updated to verify both versions work correctly. The comment you're seeing was on the older diff before I made the changes.

- Add instance getName() method to PostCreatedEvent - Restructure tests to match the pattern used by other events - Add tests for getName (static and instance), getPostId, toJSON, fromJSON, and round-trip serialization - Add null validation test for fromJSON Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

mike182uk · 2026-02-19T09:16:44Z

src/activitypub/fediverse-bridge.unit.test.ts


        const post = Object.create(Post);
-        post.id = 'post-123';
+        post.id = 111;


@cursoragent this should probably be 456 if we are following the existing pattern. String references below containing post-123 should also be updated (e.g new URL('https://example.com/post/456');

Taking a look!

mike182uk · 2026-02-19T09:17:19Z

src/activitypub/fediverse-bridge.unit.test.ts

        author.isInternal = false;

        const post = Object.create(Post);
+        post.id = 222;


@cursoragent this should probably be 456 if we are following the existing pattern

Taking a look!

mike182uk · 2026-02-19T09:17:47Z

src/activitypub/fediverse-bridge.unit.test.ts

+
+        vi.mocked(postRepository.getById).mockResolvedValue(null);
+
+        const event = new PostCreatedEvent(999);


@cursoragent this should probably be 123 if we are following the existing pattern

Taking a look!

- Changed post.id from 111 to 456 in Article test to follow existing pattern - Updated URL references from post-123 to 456 Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

- Updated external accounts test to use post.id = 456 - Updated post not found test to use 456 Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

mike182uk · 2026-02-19T09:18:51Z

src/feed/feed-update.service.unit.test.ts

                audience: Audience.FollowersOnly,
            });
+            // biome-ignore lint/suspicious/noExplicitAny: Test helper to set post id
+            (post as any).id = 124;


@cursoragent this should probably be 123

Taking a look!

mike182uk · 2026-02-19T09:19:02Z

src/feed/feed-update.service.unit.test.ts

                audience: Audience.Direct,
            });
+            // biome-ignore lint/suspicious/noExplicitAny: Test helper to set post id
+            (post as any).id = 125;


@cursoragent this should probably be 123

This has already been addressed in my last commit. All the post IDs in the feed-update.service.unit.test.ts file are now set to 123:

Line 101: (post as any).id = 123;

Line 125: (post as any).id = 123;

Line 144: new PostCreatedEvent(123)

Line 148: expect(postRepository.getById).toHaveBeenCalledWith(123);

The comment you're seeing was on the older diff before I made the changes.

Follow existing pattern where 123 is used for IDs in not-found scenarios Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

All PostCreatedEvent tests now use 123 for the post ID Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

fix: apply biome formatting to notification-event.service.unit.test.ts

d6a74d2

Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

mike182uk commented Feb 18, 2026

View reviewed changes

cursor bot temporarily deployed to staging February 18, 2026 15:47 Inactive

mike182uk commented Feb 19, 2026

View reviewed changes

cursoragent and others added 2 commits February 19, 2026 09:17

fix: use consistent post ID (456) in fediverse-bridge tests

1294677

- Changed post.id from 111 to 456 in Article test to follow existing pattern - Updated URL references from post-123 to 456 Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

fix: use 456 for post ID in remaining fediverse-bridge tests

512c080

- Updated external accounts test to use post.id = 456 - Updated post not found test to use 456 Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

mike182uk commented Feb 19, 2026

View reviewed changes

cursoragent and others added 2 commits February 19, 2026 09:19

fix: use 123 for post ID in 'post not found' test

7dcabe0

Follow existing pattern where 123 is used for IDs in not-found scenarios Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

fix: use consistent post ID (123) in feed-update.service tests

ca8929d

All PostCreatedEvent tests now use 123 for the post ID Co-authored-by: Michael Barrett <mike182uk@users.noreply.github.com>

mike182uk marked this pull request as ready for review February 19, 2026 09:23

cursor bot temporarily deployed to staging February 19, 2026 09:30 Inactive


		import { PostCreatedEvent } from '@/post/post-created.event';

		describe('PostCreatedEvent', () => {


		vi.mocked(postRepository.getById).mockResolvedValue(null);

		const event = new PostCreatedEvent(999);

Uh oh!

Conversation

mike182uk commented Feb 18, 2026

Uh oh!

cursor bot commented Feb 18, 2026

Uh oh!

coderabbitai bot commented Feb 18, 2026

Review skipped

Uh oh!

mike182uk Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

mike182uk Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mike182uk Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

mike182uk Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

mike182uk Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

mike182uk Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

mike182uk Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

cursor bot Feb 18, 2026 •

edited

Loading

cursor bot Feb 19, 2026 •

edited

Loading