Complimentary offer access #25764
Closed
Complimentary offer access #25764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: peter <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Closing as duplicate of #25889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 🎊!
Please take a minute to explain the change you're making:
Complimentary subscribers are currently unable to view offers in Ghost Portal because they are incorrectly classified, preventing them from accessing discounted upgrade paths. This blocks a key use case where site owners want to convert complimentary members to paid subscribers via special offers.
This PR modifies the
handleOfferQuerymethod inapps/portal/src/app.jsto explicitly allow both free and complimentary members to view offers. Previously, only strictly "non-paid" members could see offers, excluding complimentary members who are technicallymember.paid === true.This enables Ghost users (site owners) to effectively utilize offers to convert complimentary subscribers into paying members at a discounted rate. It provides a flexible way to engage complimentary audiences and drive revenue, aligning with the existing "Change plans" functionality but with the added benefit of offer-based discounts.
Please check your PR against these items:
We appreciate your contribution! 🙏
Linear Issue: ONC-1343