Skip to content

Removed announcementBar feature flag#26196

Open
EvanHahn wants to merge 1 commit intomainfrom
announcementBar-flag-begone
Open

Removed announcementBar feature flag#26196
EvanHahn wants to merge 1 commit intomainfrom
announcementBar-flag-begone

Conversation

@EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Feb 3, 2026

ref f9f5f72

This change should have no user impact.

The announcementBar feature flag has been enabled since 2023. We can remove the flag and assume it's always on.


Note

Low Risk
Small flag-removal change that mainly deletes gating and updates tests; risk is limited to unintentionally exposing /api/announcement where it was previously blocked by misconfiguration.

Overview
Removes the announcementBar labs feature flag from the admin feature service and from shared labs GA flag handling.

The members /api/announcement route is no longer protected by labs.enabledMiddleware('announcementBar'), and related test fixtures/snapshots are updated to stop expecting or setting the flag in config/labs payloads.

Written by Cursor Bugbot for commit f615015. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Walkthrough

Removed the announcementBar feature flag from test fixtures, the public FeatureService declaration, the members route middleware guard, and the core GA_FEATURES list; references to the flag were deleted from initialization and exposure points.

Possibly related PRs

Suggested reviewers

  • troyciesco
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the announcementBar feature flag, which aligns with all file changes across the codebase.
Description check ✅ Passed The description is detailed and directly related to the changeset, explaining the rationale (flag enabled since 2023), specific changes made, and risk assessment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch announcementBar-flag-begone

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn force-pushed the announcementBar-flag-begone branch from f615015 to 2e3bbc7 Compare February 3, 2026 22:42
ref f9f5f72

*This change should have no user impact.*

The `announcementBar` feature flag has been enabled since 2023. We can
remove the flag and assume it's always on.
@EvanHahn EvanHahn force-pushed the announcementBar-flag-begone branch from 2e3bbc7 to 26aa2e2 Compare February 5, 2026 19:24
@EvanHahn EvanHahn added the ok to merge for me You can merge this on my behalf if you want. label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok to merge for me You can merge this on my behalf if you want.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant