Open
Conversation
Contributor
WalkthroughRemoved the Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f615015 to
2e3bbc7
Compare
ref f9f5f72 *This change should have no user impact.* The `announcementBar` feature flag has been enabled since 2023. We can remove the flag and assume it's always on.
2e3bbc7 to
26aa2e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref f9f5f72
This change should have no user impact.
The
announcementBarfeature flag has been enabled since 2023. We can remove the flag and assume it's always on.Note
Low Risk
Small flag-removal change that mainly deletes gating and updates tests; risk is limited to unintentionally exposing
/api/announcementwhere it was previously blocked by misconfiguration.Overview
Removes the
announcementBarlabs feature flag from the admin feature service and from shared labs GA flag handling.The members
/api/announcementroute is no longer protected bylabs.enabledMiddleware('announcementBar'), and related test fixtures/snapshots are updated to stop expecting or setting the flag in config/labs payloads.Written by Cursor Bugbot for commit f615015. This will update automatically on new commits. Configure here.