Fix: Timezone dropdown label does not account for DST #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a GMT offset string that is DST aware, and is prepended to the label value.
…s supported by most modern browsers, so should be safe.
niranjan-uma-shankar
changed the title
Uses longOffset to simplify the regex match and code.
This was referenced Aug 2, 2025
troyciesco
requested changes
Aug 11, 2025
There was a problem hiding this comment.
@niranjan-uma-shankar before I dig too deep into this - could you add some tests for the new functions? Thanks!
packages/timezone-data/src/index.ts
Outdated
| }; | ||
|
|
||
| const labelWithGMTOffset = (label: string, offsetString: string): string => { | ||
| return '(' + offsetString + ') ' + label; |
There was a problem hiding this comment.
nit: could use a template literal here to stay consistent with L308
There was a problem hiding this comment.
Makes sense, I've updated with this change.
…inutes (2) added a try/catch block for graceful failure
@troyciesco I've added tests now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TryGhost/Ghost#24559. The Admin facing changes are implemented in TryGhost/Ghost#24557, and needs to be deployed along with this PR.
Changes:
timezoneDataWithGMTOffset()function dynamically prepends the GMT offset to the label, thereby ensuring that it respects DST.formatter.formatToParts().