Skip to content

Adopt config:best-practices and automerge packageManager updates#9

Closed
ErisDS wants to merge 1 commit intomainfrom
chore/renovate-best-practices-package-manager
Closed

Adopt config:best-practices and automerge packageManager updates#9
ErisDS wants to merge 1 commit intomainfrom
chore/renovate-best-practices-package-manager

Conversation

@ErisDS
Copy link
Member

@ErisDS ErisDS commented Mar 2, 2026

Summary

  • switch the shared preset base from config:recommended to config:best-practices
  • keep :maintainLockFilesWeekly and security:minimumReleaseAgeNpm explicitly listed with comments as non-negotiable safeguards
  • include packageManager in the automerge dep types so Renovate can automerge pnpm package manager bumps when CI passes

Why

This keeps our custom Ghost Renovate behavior while inheriting upstream best-practice hardening, and fixes the gap where pnpm package manager updates were left manual despite our automerge policy.

Align the shared preset with Renovate's best-practices baseline while preserving explicit lockfile and minimum release-age safeguards. Include packageManager dep type in the automerge rule so pnpm version bumps can merge automatically once checks pass.
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71f05eb and cf25ef6.

📒 Files selected for processing (1)
  • quiet.json5

Walkthrough

The pull request modifies the Renovate configuration file quiet.json5 with four main changes: replacing the config:recommended preset with config:best-practices in the extends section, re-introducing the :maintainLockFilesWeekly rule with an expanded explanatory comment, adjusting wording in a comment about Vite from a direct note to a core-recommendation note, and adding packageManager as a dependency type within the matchDepTypes field of both the automerge rule and its corresponding packageRules block. The net change results in 10 lines added and 9 lines removed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main changes: adopting a new config preset and adding packageManager to automerge, matching the actual changeset.
Description check ✅ Passed The description is directly related to the changeset, covering the three main changes: config preset switch, explicit lockfile rules, and packageManager automerge inclusion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/renovate-best-practices-package-manager

Comment @coderabbitai help to get the list of available commands and usage tips.

@ErisDS
Copy link
Member Author

ErisDS commented Mar 2, 2026

Superseded by #10 and #11, which split this work into separate focused changes.

@ErisDS ErisDS closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant