fix: Better QSS handling in invite links, proper redialing on disconnects, resetting LFA join status when in intermediate state on disconnect#3012
Merged
islathehut merged 17 commits intodevelopfrom Dec 1, 2025
Conversation
…disconnect when necessary
adrastaea
requested changes
Nov 8, 2025
Collaborator
adrastaea
left a comment
adrastaea
left a comment
There was a problem hiding this comment.
One change needed in onPeerDisconnected to avoid an uncaught exception if the user disconnects from a peer while their chain context is in the InviteeMemberContext state and does not have team defined in their sigchain, but otherwise fine
| * information in their chain yet resulting in an invalid device error) | ||
| */ | ||
| const oldJoinStatus = this.joinStatus | ||
| if (this.sigChainService.team == null) { |
Collaborator
There was a problem hiding this comment.
I believe this condition will always be true and if it's not then it will throw an error because SigchainService.team returns this.getActiveChain().team! which asserts that it is true.
This was
linked to
issues
Nov 14, 2025
adrastaea
approved these changes
Nov 14, 2025
…into fix/handle-aws-qss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: