Remove Unused Leveldown Binaries and Config from Desktop#3035
Remove Unused Leveldown Binaries and Config from Desktop#3035bitmold wants to merge 2 commits intoTryQuiet:developfrom
Conversation
05e0c3f to
986f82f
Compare
|
cc @holmesworcester this PR doesn't do anything other than remove unused leveldown DB binaries (that are named very similarly to binaries Quiet actually uses and of course needs to function - the once this is merged, other devs won't have to waste time trying to wrap their head around which bin is doing what like i did |
|
Closing, just threw these 2 commits on this forgotten PR onto the related #3092 |
In Quiet,
leveldownwas replaced with a (now pretty outadted) version ofclassic_levela few years ago.This PR removes some unsued json+js, as well as unused
leveldownbinaries for mac + windows + linux , hopefully simplifying some of the confusion around Quiet's leveldb integration.Am able to run
npm run start:desktopand upload images just fine without these.You'll notice that binaries for iOS and Android still exist on this PR, that's because similar work to get rid of
leveldownon mobile is in my mobile PR #3011.Haven't tested this locally on Windows like i have linux + mac..., but the Windows CI seems fine