IPFS Profile Photos #3048
Merged
IPFS Profile Photos #3048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quiet will still load the old base64-inlined profile photos, but new photos will be attached to profiles with an IPFS CID.
mcginty
force-pushed
the
mcginty/profile-photo-attachments
branch
from
3a10047 to
3befa86
Compare
| try { | ||
| yield all([takeEvery(usersActions.saveUserProfile.type, saveUserProfileSaga, socket)]) | ||
| yield all([ | ||
| takeEvery(usersActions.saveUserProfile.type, saveUserProfileSaga, socket), |
Collaborator
There was a problem hiding this comment.
Claude insists that this creates nested watchers:
This creates nested watchers - every updateUserProfiles dispatch spawns a new takeEvery watcher. Should either be fork(downloadProfilePhotosSaga) once, or the inner saga should not use takeEvery.
Is this a valid issue or a false positive?
Collaborator
Author
There was a problem hiding this comment.
Ahhhh, after looking a bit into how this works, I think this is in fact an issue, which will cause new permanent child tasks to keep spawning with every run. Nice catch.
adrastaea
approved these changes
Jan 15, 2026
Collaborator
Author
|
You're a hero @adrastaea |
Collaborator
|
One note, please update the changelog before pushing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration
This update deprecates the previous profile photo method of setting a base64-encoded image URI within the profile metadata, in favor of using the IPFS attachment upload pipeline.
Old profile photos are still displayed as expected, but when a new profile photo is set, it will only use the new IPFS flow, so older clients will not see a photo. I can change this to do both at the same time, but that feels like it defeats the purpose a bit, and we're at the turn of a new major version here as well.
Approach
This creates a new "virtual channel" for attachment photos so that we can reuse as much of the same image attachment processing pipeline as possible.
Some things obviously couldn't be handled the same, though, so you'll notice some conditional handling of profile photo attachments that stray from the typical assumption that an attachment is associated with a message in a viewable chat room.
Fixes #2926.