Merged
Conversation
* ran pod install on top of develop, with some of my changes from the mega PR * Ios nodejsmobile 18.20.4 upgrade (#3021) * Quiet builds on irl iphone in xcode 26.1 - removed unused C++ code, fixed trivial Quiet C++ warnings - project targets min ios sdk of 17.1 - added build scirpt phase shell script for people using nvm to manage nodejs - reran pod install - free()'d heap allocated memory after use closing #3014 * xcode project cleanup, removed more compiler warnings in C++ * xcode project cleanup, removed more compiler warnings in C++ * - Use nodejs mobile version 18.20.4 matching rest of project - Removed framework binary stripping build phase from xcode, it only affected the new nodejs binary and is no longer needed since nodejs mobile is now an .xcodeframework instead of a .framework (ie, at build time the correct architecture (iphone arm64, sim arm64, sim x86_64) is chosen - Updated rn_bridge.cpp to support new nodejs version * Small xcode changes from after building the cherry-picked ios nodejs mobile 18.20.4 changes againts develop --------- Co-authored-by: Isla <5048549+islathehut@users.noreply.github.com>
* classic-level binary only has arm64 code in it, since Apple was complaining about the x86_64 simulator code in this binary when Isla uploaded a build to testflight * quiet only needs classic-level, not leveldown.framework binary, it doesn't use it! * replace other binary in repo for time being...
* bump from react native 0.73.2->0.73.3
* bump from react-native 0.73.3 -> 0.73.11
* upgrade from react native 0.73.11 -> 0.74.7
* rn 75
* react native 77.3 building on android
* seemingly fix test by changing "37" to {37}
* fix snapshots that now render view with style: flex: 1
* add transformIgnorePatterns so jest doesnt fail on @d11/react-native-fast-image
* remove massive console.erorr when runnign mobile tests
* Use 16KB Aligned javascript core on Android (libjsc.so and its friends)
This change fetches the new aligned binary from Maven instead like a regular Android dependency instead of from the
JavaScript project via npm. Therefore no iOS/desktop changes are a part of this PR.
* Bump Android Gradle Plugin to 8.13.2, Bump guava in app/build.gradle and remove TODO comments
* - Found memory leak in own-native-bridge.cpp, heap allocated arguements to pass into node are never freed.
- Otherwise cleaned up C++ code with suggestions from clang-tidy
* react-dom should match react version in mobile, was 18.2.0 now is 18.3.1... notably react 18.3.0 only adds warnings to assist upgrading to react 19, but still they should match
* you dont need a C++ function to redefine a string already in javaland
* dont show Link copied! confirmation box when copying on Android 33+ as the system already does this
* you dont need a C++ function to redefine a string already in javaland
* Cherry-picked from #3011 commits override js-yaml and node-forge versions dealing with these two vulns:
GHSA-mh29-5h37-fv8m
GHSA-554w-wpv2-vw27
* more android cleanups, migration in gradle towards Kotlin DSL
* reset react test renderer to correct version, somehow changed and was breaking tests
* realized e2e github action was still based on android 34, not 35... updated
* realized Dockerfile for android still pointed to old SDK and NDK. not sure if this is even used anymore but updated
* remove the *unused* android classic-level dep in packages/backend-bundle, the one used by the androd app lives in packages/mobile/nodejs-assets * 16KB Aligned Android classic-level binary, compiled against the current nodejs-mobile binary+headers in Quiet * instructions on how to build classic-level or any other npm module with native code for android arm64 * Remove the unused android leveldown binary * added TODO for iOS stuff, remove this commit when PR is made * Removed superflous ios classic-level binary in backend-bundle package * dont need this npm task in mobile package * desktop apps dont not need leveldown dependency, just classic_level * remove unused code for leveldown in backend package * remove unused ios classic_level.node binary from backend-bundle pkg * finalized PR for reivew
This reverts commit 520867c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: