Draft
Conversation
…ts. Fixes the e2e stuff that fails on GitHub now that electron has changed versions. Added this step to new nodejs upgrade guide doc
…ditional hardcoded nodejs version config, and makes it easier to upgrade nodejs in the future and to keep tests on dev machines and github CI running with same dependencies
…e electron/node upgrade work much simpler
- Replace the (one) usage of the web File API in the renderer with new electron webUtils's API.
… some other unused npm deps in e2etests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping this as a draft until #3118 and the electron 31 PRs have been integrated.
Also just making the PR now to verify CI testing is as it should be.....
Bumps from electron 31 to 32,