Conversation
…es hacky JavaScript that was needed to override global.crypto - this was probably needed for along time because iOS was using nodejs12 until some recent work, hence having no global.crypto flag. - iOS and Android need the --experimental-global-webcrypto flag until nodejs mobile is rebuilt
bitmold
requested review from
adrastaea,
holmesworcester,
islathehut and
mcginty
mcginty
reviewed
Mar 16, 2026
|
|
||
| val command: MutableList<String> = ArrayList() | ||
| command.add("node") | ||
| command.add("--experimental-global-webcrypto") |
Collaborator
There was a problem hiding this comment.
Out of curiosity, did it fail without this flag? Looking at https://nodejs.org/api/webcrypto.html, I see that since v20.19.3 Ed25519 and X25519 are stable, but I wouldn't be surprised if there was still other experimental algorithms this was needed for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3123 Removes Superflous @peculiar/webcrypto dependency. Removes hacky JavaScript that was needed to override global.crypto