Use invariant culture as format provider

Author: Tsingis

App/Api/Setup/Endpoints.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using Asp.Versioning;
 using Microsoft.OpenApi.Any;
 using Services;
@@ -6,8 +7,8 @@ namespace Api.Setup;
 
 public static class Endpoints
 {
-    private static readonly OpenApiString ExampleFromDate = new(DateTime.Now.AddMonths(-1).ToString("yyyy-MM-dd"));
-    private static readonly OpenApiString ExampleToDate = new(DateTime.Now.ToString("yyyy-MM-dd"));
+    private static readonly OpenApiString ExampleFromDate = new(DateTime.Now.AddMonths(-1).ToString("yyyy-MM-dd", CultureInfo.InvariantCulture));
+    private static readonly OpenApiString ExampleToDate = new(DateTime.Now.ToString("yyyy-MM-dd", CultureInfo.InvariantCulture));
 
     public static void ConfigureEndpoints(this WebApplication app)
     {

App/Services/Utility/QueryHelper.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using Services.Extensions;
 
 namespace Services.Utility;
@@ -6,8 +7,8 @@ public static class QueryHelper
 {
     public static Dictionary<string, string?> CreateQueryParams(DateOnly fromDate, DateOnly toDate, string currency = "eur")
     {
-        var from = fromDate.ToUnixTimestamp().ToString();
-        var to = toDate.ToUnixTimestamp().ToString();
+        var from = fromDate.ToUnixTimestamp().ToString(CultureInfo.InvariantCulture);
+        var to = toDate.ToUnixTimestamp().ToString(CultureInfo.InvariantCulture);
         var parameters = new Dictionary<string, string?>
     {
         { "vs_currency", currency },

Directory.Build.props

@@ -14,7 +14,7 @@
     <EnforeCodeStyleInBuild>true</EnforeCodeStyleInBuild>
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <EnableCodeAnalysis>true</EnableCodeAnalysis>
-    <NoWarn>S6678;CA2007;CA1848;CA1002;CA1305;CA1062;CA2000;CA5394;CA1724;CA1031;S3267;CA1515;S1118;CA1707;CA2234;CA1051;CA1063;S3881</NoWarn>
+    <NoWarn>S6678;CA2007;CA1848;CA1002;CA1062;CA2000;CA5394;CA1724;CA1031;S3267;CA1515;S1118;CA1707;CA2234;CA1051;CA1063;S3881</NoWarn>
   </PropertyGroup>
   <ItemGroup Condition="'$(MSBuildProjectExtension)' != '.dcproj'">
     <PackageReference Include="SonarAnalyzer.CSharp">

Tests/IntegrationTests/IntegrationTests.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using System.Net;
 using FluentAssertions;
 using Xunit;
@@ -12,8 +13,8 @@ public class IntegrationTests(IntegrationFixture fixture) : IClassFixture<Integr
     public static TheoryData<string?, string?, HttpStatusCode> Cases =>
     new TheoryData<string?, string?, HttpStatusCode>
     {
-        {DateTime.Now.AddMonths(-1).ToString("yyyy-MM-dd"), DateTime.Now.ToString("yyyy-MM-dd"), HttpStatusCode.OK},
-        {DateTime.Now.AddMonths(-13).ToString("yyyy-MM-dd"), DateTime.Now.AddMonths(-12).ToString("yyyy-MM-dd"), HttpStatusCode.Unauthorized}, //Unauthorized for over 365 days old queries
+        {DateTime.Now.AddMonths(-1).ToString("yyyy-MM-dd", CultureInfo.InvariantCulture), DateTime.Now.ToString("yyyy-MM-dd", CultureInfo.InvariantCulture), HttpStatusCode.OK},
+        {DateTime.Now.AddMonths(-13).ToString("yyyy-MM-dd", CultureInfo.InvariantCulture), DateTime.Now.AddMonths(-12).ToString("yyyy-MM-dd", CultureInfo.InvariantCulture), HttpStatusCode.Unauthorized}, //Unauthorized for over 365 days old queries
         {"", null, HttpStatusCode.BadRequest},
     };
 

Tests/UnitTests/UtilityTests.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using FluentAssertions;
 using Services.Exceptions;
 using Services.Extensions;
@@ -200,8 +201,8 @@ public void CreateQueryParams_ShouldReturnCorrectDictionary()
         var fromDate = new DateOnly(2024, 8, 11);
         var toDate = new DateOnly(2024, 8, 12);
         var currency = "eur";
-        var expectedFrom = fromDate.ToUnixTimestamp().ToString();
-        var expectedTo = toDate.ToUnixTimestamp().ToString();
+        var expectedFrom = fromDate.ToUnixTimestamp().ToString(CultureInfo.InvariantCulture);
+        var expectedTo = toDate.ToUnixTimestamp().ToString(CultureInfo.InvariantCulture);
 
         var result = QueryHelper.CreateQueryParams(fromDate, toDate, currency);