Open
Conversation
In this version you will find a new fresh ui/look and feel, enhanced side bar, multiple theme, new login page, Dashboard page enhanced, Widget function enhanced, every page is now data-grid functioned , add edit delete is much easier and have enhanced look. Role and user module is enhanced and shown in different pages.
Changes in dependecies
Collaborator
|
Great job, we need to take some time to do detail code review. But there are some obvious problems I can point out. 4 Change ES6 style arrow function to ES5 normal function at the following files, that may cause some low version chrome can't compatible:
5 I don't think it's a good idea to remove the jstree resource style of widget/dataset |
Collaborator
|
I will help to forward this pr to more user group to involve in voting, thanks! |
1 it would be better to extract the duplicated code of pagination. 2 Please replace all the tab with 4 white spaces 3 Looks like you have missing files to commit http://localhost:8025/imgs/syncGrid.png 404 http://localhost:8025/imgs/syncGrid-active.png 404 http://localhost:8025/org/cboard/view/config/chart/grid.html 404 http://localhost:8025/org/cboard/view/config/chart/options/grid.html 404 4 Change ES6 style arrow function to ES5 normal function at the following files, that may cause some low version chrome can't compatible: userAdminCtrl.js dashboardViewCtrl.js widgetCtrl.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16 # What is this PR for?
In this version you will find a new fresh ui/look and feel, enhanced side bar, multiple theme, new login page, Dashboard page enhanced, Widget function enhanced, every page is now data-grid functioned , add edit delete is much easier and have enhanced look. Role and user module is enhanced and shown in different pages.
What type of PR is it?
Improvement & eature
What is the Github issue?
eg. [ES] Auto adjust time interval bucket when override of date column is null [ES] Auto adjust time interval bucket when override of date column is null #114
How should this be tested?
Just Build and run
Screenshots (if appropriate)
And other places have also been changed to list view.