Skip to content

Fixes :D#4

Open
ekeijl wants to merge 1 commit intoTuinfeesT:masterfrom
ekeijl:master
Open

Fixes :D#4
ekeijl wants to merge 1 commit intoTuinfeesT:masterfrom
ekeijl:master

Conversation

@ekeijl
Copy link

@ekeijl ekeijl commented Jun 6, 2013

  • Moved all the templates into the keuken app.
  • New models for ingredient, recipeingredient and direction
  • Fixed url redirect

- Moved all the templates into the keuken app.
- New models for ingredient, recipeingredient and direction
- Fixed url redirect
@akaIDIOT
Copy link
Member

I like the ideas in this PR, though I'm not too sure of some of the implementations:

  • / serves a single line of text rather than an index page;
  • The new model structure is not included in the admin, making the addition of a recipe impossible at the moment;
  • Including a strict set of numbered directions removes the ability to include something like a side note (serving tip, whathaveyou) to a recipe;
  • Moving all templates to keuken makes the app responsible for the inclusion of global statics like styles and scripts in stead of the project that uses the app. Not too familiar with the regular way of doing this in Django, but to me that seems like the wrong way around.

Or am I talking bullshit now? O:)

akaIDIOT added a commit that referenced this pull request Jun 16, 2013
Allows for the use of separate ingredient lists for parts of a recipe
(like the sauce on a pizza or whathaveyou). Ingredient is split up in
qunatity, unit and name to allow for future automatic multiplication
of quantities for a requested number of people.

The current admin is hard to use as it involves the creation of many
intermediate models to make up the ingredient listings for a single
recipe. That should change in the future :P

Heavily inspired by @ekeijl's approach in PR #4.

This commit also goes towards #3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants