fix: add -R flag to less for LESS_TERMCAP color support#9
Closed
fix: add -R flag to less for LESS_TERMCAP color support#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1
Adds the
-Rflag to alllessinvocations inzvm_open_less()to enable raw escape sequence passthrough.Problem
Users who rely on
LESS_TERMCAP_*environment variables for man page colors were not seeing colors when using this plugin. This is because:MANPAGER=catto capture raw man outputlesswithout the-Rflag-R, less doesn't pass through ANSI escape sequences needed for color displaySolution
Add
-Rflag to alllesscalls, which tells less to interpret raw control characters. This enables:LESS_TERMCAP_*color variables to work correctlyChanges
lib/pager.zsh: Added-Rflag to all${ZVM_MAN_PAGER}invocations inzvm_open_less()