Skip to content

fix return type hints, these changed in 0.14.0 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brondsem merged 1 commit into from
Feb 26, 2026
Merged

fix return type hints, these changed in 0.14.0 #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ming/odm/mapper.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,12 @@ class Mapper(Generic[TMappedClass]):


MongoFilter = dict
ChangeResult = dict
class _ClassQuery(Generic[TMappedClass]):
# proxies most of these from Session
def get(self, _id: Union[ObjectId|Any] = None, **kwargs) -> Optional[TMappedClass]: ...
def find(self, filter: MongoFilter = None, *args, **kwargs) -> Cursor[TMappedClass]: ...
def find_by(self, filter: MongoFilter = None, *args, **kwargs) -> Cursor[TMappedClass]: ...
def remove(self, spec_or_id: Union[MongoFilter, ObjectId] = None, **kwargs) -> ChangeResult: ...
def remove(self, spec_or_id: Union[MongoFilter, ObjectId] = None, **kwargs) -> pymongo.results.DeleteResult: ...
def count(self) -> int: ...
def find_one_and_update(self, filter: MongoFilter, update: dict, **kwargs) -> TMappedClass: ...
def find_one_and_replace(self, filter: MongoFilter, replacement: dict, *args, **kwargs) -> TMappedClass: ...
Expand All @@ -89,16 +88,16 @@ class _InstQuery(object):
# proxied from session:
def update_if_not_modified(self, obj, fields, upsert=False) -> bool: ...

def delete(self) -> ChangeResult: ...
def delete(self) -> None: ...

@type_check_only
class Query(_ClassQuery[TMappedClass], _InstQuery):

@overload # from _ClassQuery
def update(self, spec: MongoFilter, fields: dict, **kwargs) -> ChangeResult: ...
def update(self, spec: MongoFilter, fields: dict, **kwargs) -> pymongo.results.UpdateResult: ...

@overload # from _InstQuery
def update(self, fields, **kwargs) -> ChangeResult: ...
def update(self, fields, **kwargs) -> pymongo.results.UpdateResult: ...


def __getattr__(name) -> Any: ... # marks file as incomplete