SharkPool/Camera-V2 -- Refactor visibility patch #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: change existing extension
GarboMuffin
reviewed
Jan 1, 2026
|
|
||
| // save some renderer calls, packing this all into one | ||
| // while running only when isVisible is true combines this | ||
| // into a single renderer call |
Member
There was a problem hiding this comment.
this doesnt matter but updateProperties is not faster, it just calls updatePosition etc. one-by-one
Member
|
By the way, this is not a niche issue at all. Just need to hide a sprite, show it, then try to move it. It gets stuck where it was. |
GarboMuffin
added a commit
to TurboWarp/desktop
that referenced
this pull request
Jan 1, 2026
Collaborator
Author
|
Sounds pretty niche |
Member
|
do you actually think that showing a sprite then trying to move it is niche? |
Collaborator
Author
|
Niche is a funny word muffin man |
ampelectrecuted
pushed a commit
to ampelectrecuted/twextensions
that referenced
this pull request
Jan 9, 2026
…into mesh * 'mesh' of ssh://github.com/ampelectrecuted/twextensions: [Automated] Update translations 2026-01-03 (TurboWarp#2378) SharkPool/Camera: Fix critical regression from previous commit (TurboWarp#2376) SharkPool/Camera V2 -- Fix hidden sprites not receiving camera updates (TurboWarp#2372) [Automated] Update translations 2025-12-31 (TurboWarp#2374) text.js -- Add array of regex matches block (TurboWarp#2306) Revert "SharkPool/CameraV2 -- Fix hidden sprites not receiving camera updates" (TurboWarp#2371) cursor: translate cursor menu (TurboWarp#2076) SharkPool/CameraV2: Fix hidden sprites not receiving camera updates (TurboWarp#2359) local-storage: fix it generally not working (TurboWarp#2368) [Automated] Update translations 2025-12-20 (TurboWarp#2362) [Automated] Update translations 2025-12-17 (TurboWarp#2360) [Automated] Update translations 2025-12-13 (TurboWarp#2358) build(deps): bump @turbowarp/types from `c54f2cc` to `938c3ab` (TurboWarp#2355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a niche issue brought up in discord. Essentially, my code does fix sprites not receiving camera updates while hidden, but it seemed to not receive sprite updates (so normal motion blocks).
Anyways the fix was just refactoring the code, nothing too special, but it does fix the issue.