box2d: Correct mixup of the x and y coordinates #2391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The relative space type of the set position block in Box2D was set incorrectly such that it set the y position relative to the current x position rather than the y position. This means that setting inputs of -2, 20 would result in the sprite going negative in both directions, with the y coordinate always being +20 > the x coordinate. Fix was changing character 13723:62 to a y, instead of an x.
github-actions
bot
added
the
pr: change existing extension
Contributor
|
I'll investigate this |
Brackets-Coder
approved these changes
Jan 23, 2026
Contributor
Brackets-Coder
left a comment
Brackets-Coder
left a comment
There was a problem hiding this comment.
Can confirm this fixes a typo that breaks expected behavior. Nice catch!
- I tested all modified functionality and found no bugs or unintuitive behavior.
- I believe a well-formed project using an older version of this extension will not be broken by this new version. -
some projects may use workarounds to fix this manually, so fixing it in the extension may break their workarounds. I can't confirm this but it's such a trivial change that I'm going to approve - I have no additional concerns.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
oops accidentally double-commented @SharkPool-SP or @PPPDUD could you review and approve so we can get this merged? |
Collaborator
|
This will break compatibility |
Contributor
|
Yes, it will, but is it a sacrifice we're willing to make? It's likely that we're going to have users create issues about it not working if this is merged but it's also not working as intended right now |
Collaborator
|
Eh good point |
SharkPool-SP
approved these changes
Jan 23, 2026
Contributor
|
Alright I'ma go ahead and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative space type of the set position block in Box2D was set incorrectly such that it set the y position relative to the current x position rather than the y position.
This means that setting inputs of -2, 20 would result in the sprite going negative in both directions, with the y coordinate always being +20 > the x coordinate. (see below video)
The following video shows the incorrect behavior (current) and the corrected behavior (this patch) using the same script:
box2d-tw-change-showcase.mp4
Didn't look before making this change but I'm pretty sure this patch resolves this issue:
Fixes #935
Also, I think this bug is almost 7 years old, since I found the original patch in Griffpatch's VM fork, and it's from February 2019.