Introduced tstyche for type checking and to guard against unintentional API changes#3020
Merged
smallsaucepan merged 2 commits intoTurfjs:masterfrom Feb 8, 2026
Merged
Conversation
…al API changes. For example, a test like this would have caught Turfjs#3006
Member
Author
|
Example error output: |
6 tasks
mfedderly
approved these changes
Feb 6, 2026
Collaborator
mfedderly
left a comment
There was a problem hiding this comment.
This PR seems pretty reasonable as well. I'm swayed by the argument that tsd is relatively unmaintained and tstyche is the replacement. It also doesn't ship as a dependency to our users, so worst case we just have to rework Turf itself. It seems like most of these libraries are standardizing around pretty similar APIs so worst case we can probably translate to another tool later if we have to.
|
Thanks. I appreciate your choice! Please ping me if there are any questions in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced TSTyche for type checking and to guard against unintentional API changes. For example, a test like this would have caught #3006
This is a second PR to compare with a similar solution using tsd #3015
Please provide the following when creating a PR:
contributorsfield ofpackage.json- you've earned it! 👏