-
Notifications
You must be signed in to change notification settings - Fork 2
replace filldist
with product_distribution
#39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@penelopeysm, the model is not optimised for performance, but removes some heuristics from the early days of Julia and Turing |
5baa45f
to
ff99b21
Compare
replace `filldist` with `product_distribution`
product_distribution
filldist
with product_distribution
This is ready for reviewing. Mooncake's performance is generally better with |
Thanks Hong. I'm mildly concerned about the use of In any case I don't consider this to be a problem for ADTests because the model definition is shown on the website so all this information is given upfront, so will merge. |
Mooncake's performances are consistently better after switching to
product_distribution
fromfilldist / arraydist
.Before the change (results on
main
)After the change