Improve error message when initial_params / initial_state has wrong length #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
force-pushed
the
py/initial-params-error
branch
from
174802b to
d6f10ff
Compare
|
AbstractMCMC.jl documentation for PR #163 is available at: |
penelopeysm
force-pushed
the
py/initial-params-error
branch
from
d6f10ff to
a05e3aa
Compare
penelopeysm
force-pushed
the
py/initial-params-error
branch
from
a05e3aa to
c67800b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. TuringLang/Turing.jl#2557
check_initial_...is only used when sampling multiple chains (it doesn't check the actual number of parameters in the model because AbstractMCMC has no way of knowing this), so the old error message was arguably misleading.