Skip to content

Remove DEBUG constant#389

Merged
devmotion merged 1 commit intomasterfrom
dw/DEBUG
Feb 20, 2025
Merged

Remove DEBUG constant#389
devmotion merged 1 commit intomasterfrom
dw/DEBUG

Conversation

@devmotion
Copy link
Member

IMO it's easier to enable debug log messages with JULIA_DEBUG or a custom logger.

@yebai yebai requested a review from mhauru February 20, 2025 09:24
Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @devmotion. Just needs a minor version bump.

@devmotion
Copy link
Member Author

Just needs a minor version bump.

Should we do that after possibly some of the other PRs are merged as well? Or would you like to tag a release right away?

@mhauru
Copy link
Member

mhauru commented Feb 20, 2025

Happy to wait for the other PRs to get in.

@devmotion devmotion merged commit 63bd6b0 into master Feb 20, 2025
17 checks passed
@devmotion devmotion deleted the dw/DEBUG branch February 20, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants