Conversation
Member
Let's avoid a hard dependency on MCMCLogDensityProblems from AHMC. |
Collaborator
Author
|
Now MCMCLogDensityProblems is only used for tests, but without the generative hessian utilities from MCMCLogDensityProblems, users might have to build a Riemannian manifold metric with |
Member
|
@ErikQQY, it seems the new files in this PR are copied from the Can you try to move or rename these files instead of copying them, so that we can preserve the Git history of these codes? |
5129015 to
73cb714
Compare
Member
|
@ErikQQY, it might be easier to open a new PR from scratch where
This makes it easier for Git to recognise and track the changes. |
Collaborator
Author
|
Close in favor of #437 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Riemannian manifold HMC from "Riemann manifold Langevin and Hamiltonian Monte Carlo methods" which is implemented in the research directory but has not been merged into the package.
Though this PR is relatively complete, there are still some things TODO:
DenseRiemannianMetric, e.g., how should the metric tensorGbe provided, etc.