Unify argument order in phasepoint and transition#435
Merged
Conversation
yebai
requested changes
Apr 30, 2025
* Update cuda.jl * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
|
It is more prudent to mark this as a breaking release, given that some other packages likely depend on |
yebai
reviewed
Apr 30, 2025
Collaborator
Author
Yeah, I bumped the version to 0.8.0, so we can release a breaking change. As far as I know, Turing.jl is using |
mhauru
previously approved these changes
May 1, 2025
Member
mhauru
left a comment
mhauru
left a comment
There was a problem hiding this comment.
Looks all good to me. Thanks for this, I think I've tripped over that argument ordering once or twice myself.
yebai
previously approved these changes
May 1, 2025
Member
|
Excellent work - @ErikQQY, can you add an item to HISTORY.md before merging? |
yebai
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #248
Now we should only use
transition(rng, h, τ, z)ortransition(rng, h, κ, z).