Skip to content

Add getparams and setparams!! following AbstractMCMC v5.5 and v5.6 #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Add getparams and setparams!! following AbstractMCMC v5.5 and v5.6 #103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c1c0d6
add `getparams` and `setparams!!`
sunxd3 Oct 21, 2024
63b2cf1
add BangBang as dep, add functions for `GradientTransition`
sunxd3 Oct 22, 2024
44c3573
increase atol
sunxd3 Oct 22, 2024
797f871
Update test/runtests.jl
sunxd3 Oct 23, 2024
58162a3
update functions with `model` arguments
sunxd3 Oct 28, 2024
e902811
fix test errors
sunxd3 Oct 31, 2024
56d6f32
remove BangBang dep
sunxd3 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "AdvancedMH"
uuid = "5b7e9947-ddc0-4b3f-9b55-0d8042f74170"
version = "0.8.3"
version = "0.8.4"

[deps]
AbstractMCMC = "80f14c24-f653-4e6a-9b94-39d6b0f70001"
Expand All @@ -23,7 +23,7 @@ AdvancedMHMCMCChainsExt = "MCMCChains"
AdvancedMHStructArraysExt = "StructArrays"

[compat]
AbstractMCMC = "5"
AbstractMCMC = "5.5"
DiffResults = "1"
Distributions = "0.25"
FillArrays = "1"
Expand Down
10 changes: 10 additions & 0 deletions src/AdvancedMH.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ module AdvancedMH

# Import the relevant libraries.
using AbstractMCMC
using AbstractMCMC: BangBang
using Distributions
using LinearAlgebra: I
using FillArrays: Zeros
Expand Down Expand Up @@ -140,6 +141,15 @@ function __init__()
end
end

# AbstractMCMC.jl interface
function AbstractMCMC.getparams(t::Transition)
return t.params
end

function AbstractMCMC.setparams!!(t::Transition, params)
return BangBang.setproperty!!(t, :params, params)
end

# Include inference methods.
include("proposal.jl")
include("mh-core.jl")
Expand Down
10 changes: 10 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using AdvancedMH
using AbstractMCMC
using DiffResults
using Distributions
using ForwardDiff
Expand Down Expand Up @@ -33,6 +34,15 @@ include("util.jl")
LogDensityProblems.logdensity(::typeof(density), θ) = density(θ)
LogDensityProblems.dimension(::typeof(density)) = 2

@testset "getparams/setparams!! (AbstractMCMC interface)" begin
test_spl = StaticMH([Normal(0, 1), Normal(0, 1)])
t, _ = AbstractMCMC.step(Random.default_rng(), model, test_spl)
@test AbstractMCMC.getparams(t) == t.params
@test AbstractMCMC.setparams!!(t, AbstractMCMC.getparams(t)) == t
t_replaced = AbstractMCMC.setparams!!(t, (μ=1.0, σ=2.0))
@test t_replaced.params == (μ=1.0, σ=2.0)
end

@testset "StaticMH" begin
# Set up our sampler with initial parameters.
spl1 = StaticMH([Normal(0,1), Normal(0, 1)])
Expand Down
Loading