Pass kwargs on to Libtask #118
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, we'd like to merge the AdvancedPS code to Turing.jl. Libtask was holding us back; now, it is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies LibtaskExt to allow sampling from Turing models with keyword arguments with SMC or PG. See TuringLang/Turing.jl#2660 for usage.
It's hacky: it assumes that
AbstractGenericModelhas fields calledfargsandkwargs. (Or at least, it assumes that anyAbstractGenericModelthat you might ever want to pass toLibtaskModelhas those fields.) This is certainly wrong. If the plan is to eventually move all of LibtaskExt to Turing.jl itself, then this can be fixed nicely by dispatching on a type that Turing owns. For this reason, I don't consider this ready for merging; but I wanted to put the code up so that it can be discussed if needed.