-
Notifications
You must be signed in to change notification settings - Fork 12
Update SSMProblems
interface
#119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage ? 96.27%
=======================================
Files ? 8
Lines ? 430
Branches ? 0
=======================================
Hits ? 414
Misses ? 16
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdvancedPS.jl documentation for PR #119 is available at: |
Notes@THargreaves I almost managed to get the Levy-SSM working, but fell short when defining the I also noticed the docs haven't successfully built in quite a long time, so I update the compat entry for Documenter since that seemed to cause issues with Lastly, feel free to make any changes you see fit. |
It's interesting coming to review my original code, now that I'm more comfortable with Lévy processes. It actually doesn't look like this implementation is correct. I wrote the Lévy example before we had a RBPF implemented. The idea was to treat the subordinator jump simulation as part of the randomness of the transition dynamics. This works fine if you are just filtering (only using This means that the logpdf of the distribution returned by I made a proper Lévy SSM example using the RBPF for the Fusion paper. It's currently a bit broken after the interface changes we've made, but I can fix that and link to that repo from SSMProblems.jl README. This can replace this example (especially since Hong suggested we gradually move these Markovian examples out of AdvancedPS.jl). I suggest given this implementation isn't actually correct, we remove this example. |
With the addition of the state prior, there are a few minor changes that need to be made to the interface.
I am not entirely happy about how I handle the
TracedSSM
containers since we have no type information without sampling from the state prior first.