move mutable struct outside loop in test

[penelopeysm]

closes #954

actually quite confused why NamedTuple doesn't work, but ok

[github-actions]

Benchmark Report for Commit 9913794

Computer Information

Julia Version 1.11.6
Commit 9615af0f269 (2025-07-09 12:58 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.1 |                 1.5 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                654.8 |                44.3 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                313.7 |                74.4 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1241.4 |                28.3 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               6749.1 |                27.8 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1463.8 |                29.4 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |               1014.8 |                 4.4 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5798.1 |                 4.0 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |                983.1 |                 9.0 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              65567.8 |                 3.6 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8457.8 |                10.2 |
|               Dynamic |        10 |    mooncake |             typed |   true |                141.2 |                12.5 |
|              Submodel |         1 |    mooncake |             typed |   true |                 13.8 |                 5.4 |
|                   LDA |        12 | reversediff |             typed |   true |               1306.7 |                 2.2 |

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.16%. Comparing base (1ed8cc8) to head (9913794).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1014   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files          38       38           
  Lines        3935     3935           
=======================================
  Hits         3233     3233           
  Misses        702      702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coveralls]

Pull Request Test Coverage Report for Build 16809853778

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 27 unchanged lines in 5 files lost coverage.
• Overall coverage remained the same at 82.411%

---

Files with Coverage Reduction	New Missed Lines	%
src/model.jl	1	86.73%
src/extract_priors.jl	3	55.88%
src/values_as_in_model.jl	5	64.0%
src/pointwise_logdensities.jl	6	87.5%
src/threadsafe.jl	12	64.66%

Totals
Change from base Build 16804421724:	0.0%
Covered Lines:	3233
Relevant Lines:	3923

---

💛 - Coveralls

[penelopeysm]

This is very trivial, will just merge.

[coveralls]

Pull Request Test Coverage Report for Build 16809853778

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 27 unchanged lines in 5 files lost coverage.
• Overall coverage remained the same at 82.411%

---

Files with Coverage Reduction	New Missed Lines	%
src/model.jl	1	86.73%
src/extract_priors.jl	3	55.88%
src/values_as_in_model.jl	5	64.0%
src/pointwise_logdensities.jl	6	87.5%
src/threadsafe.jl	12	64.66%

Totals
Change from base Build 16804421724:	0.0%
Covered Lines:	3233
Relevant Lines:	3923

---

💛 - Coveralls