Skip to content

v0.38 #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

v0.38 #1018

wants to merge 6 commits into from

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Aug 8, 2025

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Benchmark Report for Commit 991e825

Computer Information

Julia Version 1.11.6
Commit 9615af0f269 (2025-07-09 12:58 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.0 |                 1.5 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                658.4 |                46.0 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                421.4 |                52.2 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1146.8 |                29.4 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               6869.7 |                26.9 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1045.0 |                40.1 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |               1013.9 |                 4.6 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5814.5 |                 4.2 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |                996.0 |                 9.0 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              65004.7 |                 3.9 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8385.2 |                10.0 |
|               Dynamic |        10 |    mooncake |             typed |   true |                132.5 |                12.3 |
|              Submodel |         1 |    mooncake |             typed |   true |                 13.9 |                 4.8 |
|                   LDA |        12 | reversediff |             typed |   true |               1290.2 |                 2.6 |

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 89.39394% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.53%. Comparing base (0cf3440) to head (991e825).

Files with missing lines Patch % Lines
src/contexts/init.jl 92.30% 4 Missing ⚠️
src/model.jl 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   82.26%   82.53%   +0.26%     
==========================================
  Files          38       39       +1     
  Lines        3947     4008      +61     
==========================================
+ Hits         3247     3308      +61     
  Misses        700      700              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16862187845

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.6%) to 79.99%

Totals Coverage Status
Change from base Build 16862061135: -2.6%
Covered Lines: 3142
Relevant Lines: 3928

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 10, 2025

Pull Request Test Coverage Report for Build 16862187845

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 82.075%

Totals Coverage Status
Change from base Build 16862061135: -0.5%
Covered Lines: 3228
Relevant Lines: 3933

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 10, 2025

Pull Request Test Coverage Report for Build 16943750469

Details

  • 59 of 66 (89.39%) changed or added relevant lines in 3 files are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.3%) to 82.783%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model.jl 8 11 72.73%
src/contexts/init.jl 48 52 92.31%
Files with Coverage Reduction New Missed Lines %
src/model.jl 1 85.48%
src/simple_varinfo.jl 2 71.43%
src/varinfo.jl 6 84.99%
src/threadsafe.jl 10 64.86%
Totals Coverage Status
Change from base Build 16942570157: 0.3%
Covered Lines: 3308
Relevant Lines: 3996

💛 - Coveralls

Copy link
Contributor

DynamicPPL.jl documentation for PR #1018 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1018/

* Implement InitContext

* Fix loading order of modules; move `prefix(::Model)` to model.jl

* Add tests for InitContext behaviour

* inline `rand(::Distributions.Uniform)`

Note that, apart from being simpler code, Distributions.Uniform also
doesn't allow the lower and upper bounds to be exactly equal (but we
might like to keep that option open in DynamicPPL, e.g. if the user
wants to initialise all values to the same value in linked space).

* Document

* Add a test to check that `init!!` doesn't change linking

* Fix `push!` for VarNamedVector

This should have been changed in #940, but slipped through as the file
wasn't listed as one of the changed files.

* Add some line breaks

Co-authored-by: Markus Hauru <[email protected]>

* Add the option of no fallback for ParamsInit

* Improve docstrings

* typo

* `p.default` -> `p.fallback`

* Rename `{Prior,Uniform,Params}Init` -> `InitFrom{Prior,Uniform,Params}`

---------

Co-authored-by: Markus Hauru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants