Skip to content

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Aug 29, 2025

replace #1024 which fails because compathelper forces newest versions of packages which forces some recent version of JET that only works on 1.12

Copy link
Contributor

github-actions bot commented Aug 29, 2025

Benchmark Report for Commit 56841ef

Computer Information

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬───────────────────┬────────┬────────────────┬─────────────────┐
│                 Model │   Dim │  AD Backend │           VarInfo │ Linked │ t(eval)/t(ref) │ t(grad)/t(eval) │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼────────────────┼─────────────────┤
│ Simple assume observe │     1 │ forwarddiff │             typed │  false │            9.0 │             1.6 │
│           Smorgasbord │   201 │ forwarddiff │             typed │  false │          679.6 │            43.7 │
│           Smorgasbord │   201 │ forwarddiff │ simple_namedtuple │   true │          441.6 │            51.8 │
│           Smorgasbord │   201 │ forwarddiff │           untyped │   true │         1224.6 │            28.9 │
│           Smorgasbord │   201 │ forwarddiff │       simple_dict │   true │         7063.1 │            27.7 │
│           Smorgasbord │   201 │ reversediff │             typed │   true │         1498.1 │            28.9 │
│           Smorgasbord │   201 │    mooncake │             typed │   true │         1054.4 │             4.5 │
│    Loop univariate 1k │  1000 │    mooncake │             typed │   true │         6074.3 │             4.2 │
│       Multivariate 1k │  1000 │    mooncake │             typed │   true │         1019.6 │             9.1 │
│   Loop univariate 10k │ 10000 │    mooncake │             typed │   true │        68500.6 │             3.8 │
│      Multivariate 10k │ 10000 │    mooncake │             typed │   true │         8665.6 │            10.1 │
│               Dynamic │    10 │    mooncake │             typed │   true │          139.8 │            11.3 │
│              Submodel │     1 │    mooncake │             typed │   true │           13.7 │             5.0 │
│                   LDA │    12 │ reversediff │             typed │   true │         1047.9 │             2.1 │
└───────────────────────┴───────┴─────────────┴───────────────────┴────────┴────────────────┴─────────────────┘

@penelopeysm
Copy link
Member Author

ok turns out that PrettyTables v3 has quite big changes which means that i'm not going to deal with it and it can be somebody else's problem (or alternatively we can just ignore compathelper)

Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.34%. Comparing base (e50d40d) to head (56841ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1026   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files          38       38           
  Lines        3949     3949           
=======================================
  Hits         3252     3252           
  Misses        697      697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Aug 29, 2025

Pull Request Test Coverage Report for Build 17881023680

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 6 files lost coverage.
  • Overall coverage remained the same at 82.601%

Files with Coverage Reduction New Missed Lines %
src/model.jl 1 86.73%
src/debug_utils.jl 3 89.27%
src/extract_priors.jl 3 60.53%
src/pointwise_logdensities.jl 3 93.06%
src/values_as_in_model.jl 4 72.41%
src/threadsafe.jl 13 62.16%
Totals Coverage Status
Change from base Build 17866549439: 0.0%
Covered Lines: 3252
Relevant Lines: 3937

💛 - Coveralls

@penelopeysm penelopeysm changed the title pretty tables pretty tables 3 Sep 20, 2025
Copy link
Contributor

DynamicPPL.jl documentation for PR #1026 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1026/

@penelopeysm penelopeysm merged commit 73113c7 into main Sep 20, 2025
21 checks passed
@penelopeysm penelopeysm deleted the py/ch branch September 20, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants