Skip to content

Don't use closure for enzyme #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2025
Merged

Don't use closure for enzyme #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbc07b7
Don't use closure for enzyme
wsmoses Sep 21, 2025
91c87d1
no annotation
wsmoses Sep 21, 2025
86b5429
Merge branch 'main' into clos
penelopeysm Sep 24, 2025
13df62f
bump patch
penelopeysm Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# DynamicPPL Changelog

## 0.37.5

A minor optimisation for Enzyme AD on DynamicPPL models.

## 0.37.4

An extension for MarginalLogDensities.jl has been added.
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "DynamicPPL"
uuid = "366bfd00-2699-11ea-058f-f148b4cae6d8"
version = "0.37.4"
version = "0.37.5"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down
1 change: 1 addition & 0 deletions src/logdensityfunction.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ closure approach will be used. By default, this function returns `false`, i.e.
the constant approach will be used.
"""
use_closure(::ADTypes.AbstractADType) = true
use_closure(::ADTypes.AutoEnzyme) = false

"""
getmodel(f)
Expand Down
6 changes: 2 additions & 4 deletions test/integration/enzyme/main.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ import Enzyme: set_runtime_activity, Forward, Reverse, Const
using ForwardDiff: ForwardDiff # run_ad uses FD for correctness test

ADTYPES = Dict(
"EnzymeForward" =>
AutoEnzyme(; mode=set_runtime_activity(Forward), function_annotation=Const),
"EnzymeReverse" =>
AutoEnzyme(; mode=set_runtime_activity(Reverse), function_annotation=Const),
"EnzymeForward" => AutoEnzyme(; mode=set_runtime_activity(Forward)),
"EnzymeReverse" => AutoEnzyme(; mode=set_runtime_activity(Reverse)),
)

@testset "$ad_key" for (ad_key, ad_type) in ADTYPES
Expand Down
Loading