-
Notifications
You must be signed in to change notification settings - Fork 36
Fixes for Turing 0.41 #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Turing 0.41 #1057
Conversation
Benchmark Report for Commit 6e67ce7Computer Information
Benchmark Results
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## breaking #1057 +/- ##
============================================
- Coverage 82.43% 82.39% -0.04%
============================================
Files 42 42
Lines 3815 3818 +3
============================================
+ Hits 3145 3146 +1
- Misses 670 672 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
One minor comment I have is that we can warn the user if they pass |
DynamicPPL.jl documentation for PR #1057 is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
Assorted fixes to get the new Turing release to work nicely with DPPL.
Things included in this PR:
setleafcontext(model, context)
convenience method (closessetleafcontext(::Model, ::AbstractContext)
#993)initial_params
in the defaultsample
call for DynamicPPL models (otherwise AbstractMCMC will insertnothing
and it will error)