Skip to content

Expand JET test #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Expand JET test #782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
080366a
Fix JET test
penelopeysm Jan 21, 2025
bae04ff
Add output if a typed varinfo isn't inferred
penelopeysm Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions test/ext/DynamicPPLJETExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@
@testset "$(model.f)" for model in DynamicPPL.TestUtils.DEMO_MODELS
# Use debug logging below.
varinfo = DynamicPPL.Experimental.determine_suitable_varinfo(model)
# They should all result in typed.
@test varinfo isa DynamicPPL.TypedVarInfo
# But let's also make sure that they're not lying.
# Check that the inferred varinfo is indeed suitable for evaluation and sampling
f_eval, argtypes_eval = DynamicPPL.DebugUtils.gen_evaluator_call_with_types(
model, varinfo
)
Expand All @@ -76,6 +74,21 @@
model, varinfo, DynamicPPL.SamplingContext()
)
JET.test_call(f_sample, argtypes_sample)
# For our demo models, they should all result in typed.
is_typed = varinfo isa DynamicPPL.TypedVarInfo
@test is_typed
# If the test failed, check why it didn't infer a typed varinfo
if !is_typed
typed_vi = VarInfo(model)
f_eval, argtypes_eval = DynamicPPL.DebugUtils.gen_evaluator_call_with_types(
model, typed_vi
)
JET.test_call(f_eval, argtypes_eval)
f_sample, argtypes_sample = DynamicPPL.DebugUtils.gen_evaluator_call_with_types(
model, typed_vi, DynamicPPL.SamplingContext()
)
JET.test_call(f_sample, argtypes_sample)
end
end
end
end
Loading