Skip to content

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Feb 13, 2025

KernelAbstractions 0.9.32 caused test failures with DynamicPPLJETExt, see here #781 (comment)

I believe 0.9.33 (and specifically JuliaGPU/KernelAbstractions.jl#557) should have fixed this.

Supersedes the CompatHelper PR #783.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.17%. Comparing base (bca344c) to head (379265c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #809   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files          36       36           
  Lines        4305     4305           
=======================================
  Hits         3710     3710           
  Misses        595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penelopeysm penelopeysm requested a review from mhauru February 13, 2025 23:17
@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13317896496

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 86.259%

Files with Coverage Reduction New Missed Lines %
src/varinfo.jl 3 84.48%
Totals Coverage Status
Change from base Build 13218978180: 0.0%
Covered Lines: 3710
Relevant Lines: 4301

💛 - Coveralls

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@penelopeysm penelopeysm added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit 84820a3 Feb 14, 2025
19 checks passed
@penelopeysm penelopeysm deleted the py/KernelAbstractions branch February 14, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants