Skip to content

Remove dead code #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025
Merged

Remove dead code #956

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99ffbbe
Remove dead code
penelopeysm Jun 16, 2025
0684573
More dead code
penelopeysm Jun 16, 2025
8907ec4
no need that too
penelopeysm Jun 16, 2025
4c14d7b
bump patch
penelopeysm Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions src/context_implementations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,4 @@
using Distributions:
UnivariateDistribution, MultivariateDistribution, MatrixDistribution, Distribution
Comment on lines -1 to -2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a blanket using Distributions in src/DynamicPPL.jl so this shouldn't be needed


const AMBIGUITY_MSG =
"Ambiguous `LHS .~ RHS` or `@. LHS ~ RHS` syntax. The broadcasting " *
"can either be column-wise following the convention of Distributions.jl or " *
"element-wise following Julia's general broadcasting semantics. Please make sure " *
"that the element type of `LHS` is not a supertype of the support type of " *
"`AbstractVector` to eliminate ambiguity."

alg_str(spl::Sampler) = string(nameof(typeof(spl.alg)))
Copy link
Member Author

@penelopeysm penelopeysm Jun 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alg_str is in fact used in the Turing test suite, but they just test that it exists, it's not actually used in any Turing library code. So I'm pretty confused. I don't see much of a point, though, because Sampler is on its way out (once TuringLang/Turing.jl#2555 is done we should be able to remove it).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I think possibly this is a holdover from the time that Sampler was more heavily used -- a lot of this was gotten rid of a couple versions ago)


# utility funcs for querying sampler information
require_gradient(spl::Sampler) = false
require_particles(spl::Sampler) = false
using Distributions: Distribution

# Allows samplers, etc. to hook into the final logp accumulation in the tilde-pipeline.
function acclogp_assume!!(context::AbstractContext, vi::AbstractVarInfo, logp)
Expand Down
Loading