-
Notifications
You must be signed in to change notification settings - Fork 36
Bump minimum Julia version to 1.10.8 (?) #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark Report for Commit 07b672bComputer Information
Benchmark Results
|
ff2a543
to
d2c0ca6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
==========================================
- Coverage 83.00% 82.97% -0.03%
==========================================
Files 36 36
Lines 3965 3965
==========================================
- Hits 3291 3290 -1
- Misses 674 675 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 16170022314Details
💛 - Coveralls |
d2c0ca6
to
82eccc3
Compare
DynamicPPL.jl documentation for PR #979 is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
This PR attempts to fix the CI crash observed on 1.10.0. The current knowledge is:
With [email protected] [email protected], the Julia runtime crashes and CI fails. https://github.com/TuringLang/DynamicPPL.jl/actions/runs/16165535432/job/45626465478
With [email protected] [email protected], the Julia runtime still spits out those errors, but CI doesn't fail. https://github.com/TuringLang/DynamicPPL.jl/actions/runs/16168303557/job/45635313517?pr=979
With [email protected] [email protected], the Julia runtime doesn't error and tests pass fine: https://github.com/TuringLang/DynamicPPL.jl/actions/runs/16168884937/job/45637230293?pr=979
Note that the runtime crash seems very similar to this one TuringLang/Bijectors.jl#368.
In that PR, the agreed-upon solution was to increase Julia compat to 1.10.8, so I've done the same here. It's not a perfect solution by any means but IMO it's the least bad option.
I have zero clue which part of Julia 1.10.8 fixed it, although this seems like the most likely one to me JuliaLang/julia@964fdf0