Skip to content

Conversation

@yebai
Copy link
Member

@yebai yebai commented Oct 23, 2025

No description provided.

@yebai yebai requested a review from mhauru October 23, 2025 12:37
@github-actions
Copy link

Libtask.jl documentation for PR #201 is available at:
https://TuringLang.github.io/Libtask.jl/previews/PR201/

MistyClosures = "2.0.0"
Test = "1"
julia = "~1.10.8, 1.11.6"
julia = "~1.10.8, 1.11.6, 1.12.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
julia = "~1.10.8, 1.11.6, 1.12.1"
julia = "~1.10.8, ~1.11.6, ~1.12.1"

If the intent is to rule out 1.12.0, I think you need the extra tilde. I would also add a tilde in front of 1.12.1 to not claim that this means compatibility with 1.13.

Note though that this means that if you install Libtask on Julia 1.12.0 you'll get an old version, because the previous release that has julia = "~1.10.8, 1.11.6" as its compat is considered compatible with 1.12.0.

We were discussing this with Will last week. In a philosophical sense Libtask and Mooncake should both have an upper bound on their Julia version compatibility, because they rely on non-public compiler internals. But we can't really introduce one any more, because Pkg will just default to installing an old version that claims to be compatible with anything up to Julia v2.0.

Given that we can't actually stop a broken version of Libtask from being installed on 1.12.0, I think it's less confusing if at least it would install the latest version of Libtask. It would also cause less trouble by holding back other packages. Hence I'm inclined to not do this change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead print a warning message if Libtask is used on Julia 1.12.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good idea.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a warning in 6c336b0

@yebai yebai closed this Oct 23, 2025
@yebai yebai deleted the yebai-patch-1 branch October 23, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants